Collapsible Quotes. Like it?

Discussion in 'ValveTime Feedback' started by Chris_D, May 3, 2012.

  1. Chris_D Administrator.

    Member Since:
    Jul 1, 2003
    Message Count:
    11,824
    Trophy Points:
    164
    Hey guys,

    By the request of some community members over at the Official XenForo forums I created an add-on to XenForo which basically collapses quotes over a certain length automatically.

    I've enabled this, but I just want to see whether you would like it to stay enabled or whether you don't much care for it.

    As you can see, that is a long quote. There is a link in the top right to read more. When you click it, the full quote is revealed.

    Shall we keep it? Or turn it off?
  2. Spiderm4N Medic

    Member Since:
    Jul 18, 2006
    Message Count:
    16
    Trophy Points:
    17
    :eek:
    This is really good, make the posts more clean, I think we should keep it.
  3. Krynn72 The Freeman

    Member Since:
    May 16, 2004
    Message Count:
    26,661
    Trophy Points:
    189
    Location:
    Connect and cut
    Neat, I like it. Does it work with images as well? Not that its much of an issue these days, but I remember when people used to quote whole image posts in the image dump.

    Also people should help me decide on a phone. ;)
  4. Yorick Guest

    Member Since:
    Message Count:
    0
    Trophy Points:
    0
    If we do end up keeping it, I'll have to replace that arrow image, because goddamn.

    The only thing that I would change about it is adding some kind of "..." where it parses.

    It also messes up if you just use [quote.] without actually targeting anyone.
  5. Chris_D Administrator.

    Member Since:
    Jul 1, 2003
    Message Count:
    11,824
    Trophy Points:
    164
    Don't diss the arrows! :eek:
  6. Vegeta897 The Freeman

    Member Since:
    Jan 12, 2004
    Message Count:
    26,518
    Trophy Points:
    194
    Location:
    These Open Fields
    I like the idea but not how it's implemented. Any collapsed quote should have a big/wide arrow at the bottom center to click to expand. The location of it now in the top right isn't very intuitive.
  7. Yorick Guest

    Member Since:
    Message Count:
    0
    Trophy Points:
    0
    Yeah, moving it would quite frankly solve both of the problems. It shouldn't be difficult to throw it in a div and align it with regards to the quote container.
  8. Chris_D Administrator.

    Member Since:
    Jul 1, 2003
    Message Count:
    11,824
    Trophy Points:
    164
    Yeah ok, I'll configure that.
  9. Vegeta897 The Freeman

    Member Since:
    Jan 12, 2004
    Message Count:
    26,518
    Trophy Points:
    194
    Location:
    These Open Fields
    [IMG]

    Something like this? Arrows look pretty bad, but a wide tab like that is visible enough without taking up vertical space. I also think a gradient would really make sure that you can tell the quote is incomplete.
  10. Chris_D Administrator.

    Member Since:
    Jul 1, 2003
    Message Count:
    11,824
    Trophy Points:
    164
    I have implemented a temporary solution for quotes with no post/name supplied.

    I will look at the suggestions by Vegeta now.
  11. TechnoHippyChic Companion Cube

    Member Since:
    Jul 23, 2003
    Message Count:
    1,644
    Trophy Points:
    94
    Location:
    Discombobula
    This is what I'm getting when expanding yours, Veg:

    [IMG]

    It's a cool effect but not very readable. Doesn't happen with the stock one.
  12. Yorick Guest

    Member Since:
    Message Count:
    0
    Trophy Points:
    0
    Vegeta's is an image example, bud. It's not actually supposed to work.
  13. Vegeta897 The Freeman

    Member Since:
    Jan 12, 2004
    Message Count:
    26,518
    Trophy Points:
    194
    Location:
    These Open Fields
    Um. Huh? Is that a subtle joke?

    Edit: Yorick beat me. I think she was joking.
  14. Chris_D Administrator.

    Member Since:
    Jul 1, 2003
    Message Count:
    11,824
    Trophy Points:
    164
    She's too smart for us.
  15. Yorick Guest

    Member Since:
    Message Count:
    0
    Trophy Points:
    0
    I'm too dumb for us.
  16. Chris_D Administrator.

    Member Since:
    Jul 1, 2003
    Message Count:
    11,824
    Trophy Points:
    164
    True.
  17. Chris_D Administrator.

    Member Since:
    Jul 1, 2003
    Message Count:
    11,824
    Trophy Points:
    164
    Implemented some of this, Vegeta897, thanks.

    I'm going to replace the text with some sort of image eventually, but this looks better for now. Hopefully you agree?
  18. Vegeta897 The Freeman

    Member Since:
    Jan 12, 2004
    Message Count:
    26,518
    Trophy Points:
    194
    Location:
    These Open Fields
    I hopefully do!

    Nice work.

    Edit: Will there be an option in the settings to always show full quotes?
  19. Chris_D Administrator.

    Member Since:
    Jul 1, 2003
    Message Count:
    11,824
    Trophy Points:
    164
    Hadn't thought about it, but not a bad idea.
  20. Vegeta897 The Freeman

    Member Since:
    Jan 12, 2004
    Message Count:
    26,518
    Trophy Points:
    194
    Location:
    These Open Fields
    For the old school chaps like me :)
  21. Yorick Guest

    Member Since:
    Message Count:
    0
    Trophy Points:
    0
    I think the button could use a bit more padding, but I definitely like it.
  22. Chris_D Administrator.

    Member Since:
    Jul 1, 2003
    Message Count:
    11,824
    Trophy Points:
    164
    Yes me too.
  23. MuToiD_MaN The Freeman

    Member Since:
    Nov 5, 2004
    Message Count:
    4,502
    Trophy Points:
    114
    Location:
    Irvine, California
    Gets my vote. Great addition!
  24. Vegeta897 The Freeman

    Member Since:
    Jan 12, 2004
    Message Count:
    26,518
    Trophy Points:
    194
    Location:
    These Open Fields
    So I guess the quote size criteria is based on character count?

    [IMG]

    Hiding 5 words that would fit on the same line anyway is useless.

    But, more importantly I would just like an option to disable this feature.
  25. Chris_D Administrator.

    Member Since:
    Jul 1, 2003
    Message Count:
    11,824
    Trophy Points:
    164
    I'm still going to look at the user preference for disabling.
  26. Stigmata The Freeman

    Member Since:
    Jun 2, 2003
    Message Count:
    16,112
    Trophy Points:
    159
    Location:
    Ontario, Canada
    A disable would be nice. I hate collapsed quotes and find no redeeming value in them whatsoever, though you guys have done pretty well with the feature itself.
  27. StarMonkey ValveTime Admin | Mighty Pirate

    Member Since:
    Jul 23, 1981
    Message Count:
    1,607
    Trophy Points:
    89
    Location:
    Essex, UK
    I like it!
  28. NeptuneUK Space Core

    Member Since:
    Aug 25, 2004
    Message Count:
    4,538
    Trophy Points:
    69
    Location:
    Somewhere in the UK
    This feature has my unwavering approval!
  29. Member Since:
    Jun 15, 2006
    Message Count:
    272
    Trophy Points:
    34
    If you have a minimum font size specified in your browser the quote tab blocks the text of the post (collapsed AND un-collapsed). I'd recommend making the containing box wider to accommodate various font sizes instead of butting the edges right up against the text.

    Attached Files:

  30. Member Since:
    Jun 15, 2006
    Message Count:
    272
    Trophy Points:
    34
    Bumping, are we leaving the quote tab able to overflow or is it being looked into?
  31. Chris_D Administrator.

    Member Since:
    Jul 1, 2003
    Message Count:
    11,824
    Trophy Points:
    164
    It is being looked into.
  32. Dog-- The Freeman

    Member Since:
    Apr 16, 2005
    Message Count:
    9,859
    Trophy Points:
    124
    Location:
    Ontario, Canada
    CBA to read this entire thread so this has probably been said, but I like it. It looks nice and neat. It's quick and easy. I especially like it for those certain people who LOVE quoting the hugest biggest posts they can find and reply with "lol".
  33. Chris_D Administrator.

    Member Since:
    Jul 1, 2003
    Message Count:
    11,824
    Trophy Points:
    164
    lol
  34. Hubicorn Hunter

    Member Since:
    Sep 2, 2012
    Message Count:
    3
    Trophy Points:
    20
    Location:
    New York, New York
    This is pretty amazing! I do have to say you guys made a great choice from switching forum software's. I've never been part of a community using XenForo and I am really enjoying using it here.
  35. Member Since:
    Jun 15, 2006
    Message Count:
    272
    Trophy Points:
    34
    The quote tab still overlaps the quoted text if you have a minimum font size specified ;)