Collapsible Quotes. Like it?

Discussion in 'ValveTime Feedback' started by Chris D, May 3, 2012.

  1. Chris D

    Chris D Administrator.
    Staff Member

    Joined:
    Jul 1, 2003
    Messages:
    11,909
    Likes Received:
    402
    Hey guys,

    By the request of some community members over at the Official XenForo forums I created an add-on to XenForo which basically collapses quotes over a certain length automatically.

    I've enabled this, but I just want to see whether you would like it to stay enabled or whether you don't much care for it.

    As you can see, that is a long quote. There is a link in the top right to read more. When you click it, the full quote is revealed.

    Shall we keep it? Or turn it off?
     
  2. Spiderm4N

    Spiderm4N Medic

    Joined:
    Jul 18, 2006
    Messages:
    19
    Likes Received:
    2
    :eek:
    This is really good, make the posts more clean, I think we should keep it.
     
    • Like Like x 1
  3. Krynn72

    Krynn72 The Freeman

    Joined:
    May 16, 2004
    Messages:
    26,073
    Likes Received:
    710
    Neat, I like it. Does it work with images as well? Not that its much of an issue these days, but I remember when people used to quote whole image posts in the image dump.

    Also people should help me decide on a phone. ;)
     
  4. Yorick

    Yorick Guest

    If we do end up keeping it, I'll have to replace that arrow image, because goddamn.

    The only thing that I would change about it is adding some kind of "..." where it parses.

    It also messes up if you just use [quote.] without actually targeting anyone.
     
    • Like Like x 1
  5. Chris D

    Chris D Administrator.
    Staff Member

    Joined:
    Jul 1, 2003
    Messages:
    11,909
    Likes Received:
    402
    Don't diss the arrows! :eek:
     
  6. Vegeta897

    Vegeta897 Banned as all fuck

    Joined:
    Jan 12, 2004
    Messages:
    26,147
    Likes Received:
    767
    I like the idea but not how it's implemented. Any collapsed quote should have a big/wide arrow at the bottom center to click to expand. The location of it now in the top right isn't very intuitive.
     
    • Like Like x 2
  7. Yorick

    Yorick Guest

    Yeah, moving it would quite frankly solve both of the problems. It shouldn't be difficult to throw it in a div and align it with regards to the quote container.
     
  8. Chris D

    Chris D Administrator.
    Staff Member

    Joined:
    Jul 1, 2003
    Messages:
    11,909
    Likes Received:
    402
    Yeah ok, I'll configure that.
     
  9. Vegeta897

    Vegeta897 Banned as all fuck

    Joined:
    Jan 12, 2004
    Messages:
    26,147
    Likes Received:
    767
    [​IMG]

    Something like this? Arrows look pretty bad, but a wide tab like that is visible enough without taking up vertical space. I also think a gradient would really make sure that you can tell the quote is incomplete.
     
    • Like Like x 3
  10. Chris D

    Chris D Administrator.
    Staff Member

    Joined:
    Jul 1, 2003
    Messages:
    11,909
    Likes Received:
    402
    I have implemented a temporary solution for quotes with no post/name supplied.

    I will look at the suggestions by Vegeta now.
     
  11. TechnoHippyChic

    TechnoHippyChic Companion Cube

    Joined:
    Jul 23, 2003
    Messages:
    1,679
    Likes Received:
    66
    This is what I'm getting when expanding yours, Veg:

    [​IMG]

    It's a cool effect but not very readable. Doesn't happen with the stock one.
     
    • Like Like x 1
  12. Yorick

    Yorick Guest

    Vegeta's is an image example, bud. It's not actually supposed to work.
     
  13. Vegeta897

    Vegeta897 Banned as all fuck

    Joined:
    Jan 12, 2004
    Messages:
    26,147
    Likes Received:
    767
    Um. Huh? Is that a subtle joke?

    Edit: Yorick beat me. I think she was joking.
     
  14. Chris D

    Chris D Administrator.
    Staff Member

    Joined:
    Jul 1, 2003
    Messages:
    11,909
    Likes Received:
    402
    She's too smart for us.
     
  15. Yorick

    Yorick Guest

    I'm too dumb for us.
     
  16. Chris D

    Chris D Administrator.
    Staff Member

    Joined:
    Jul 1, 2003
    Messages:
    11,909
    Likes Received:
    402
    True.
     
  17. Chris D

    Chris D Administrator.
    Staff Member

    Joined:
    Jul 1, 2003
    Messages:
    11,909
    Likes Received:
    402
    Implemented some of this, Vegeta897, thanks.

    I'm going to replace the text with some sort of image eventually, but this looks better for now. Hopefully you agree?
     
  18. Vegeta897

    Vegeta897 Banned as all fuck

    Joined:
    Jan 12, 2004
    Messages:
    26,147
    Likes Received:
    767
    I hopefully do!

    Nice work.

    Edit: Will there be an option in the settings to always show full quotes?
     
  19. Chris D

    Chris D Administrator.
    Staff Member

    Joined:
    Jul 1, 2003
    Messages:
    11,909
    Likes Received:
    402
    Hadn't thought about it, but not a bad idea.
     
  20. Vegeta897

    Vegeta897 Banned as all fuck

    Joined:
    Jan 12, 2004
    Messages:
    26,147
    Likes Received:
    767
    For the old school chaps like me :)
     
  21. Yorick

    Yorick Guest

    I think the button could use a bit more padding, but I definitely like it.
     
  22. Chris D

    Chris D Administrator.
    Staff Member

    Joined:
    Jul 1, 2003
    Messages:
    11,909
    Likes Received:
    402
    Yes me too.
     
  23. MuToiD_MaN

    MuToiD_MaN The Freeman

    Joined:
    Nov 5, 2004
    Messages:
    4,510
    Likes Received:
    190
    Gets my vote. Great addition!
     
  24. Vegeta897

    Vegeta897 Banned as all fuck

    Joined:
    Jan 12, 2004
    Messages:
    26,147
    Likes Received:
    767
    So I guess the quote size criteria is based on character count?

    [​IMG]

    Hiding 5 words that would fit on the same line anyway is useless.

    But, more importantly I would just like an option to disable this feature.
     
  25. Chris D

    Chris D Administrator.
    Staff Member

    Joined:
    Jul 1, 2003
    Messages:
    11,909
    Likes Received:
    402
    I'm still going to look at the user preference for disabling.
     
  26. Stigmata

    Stigmata The Freeman

    Joined:
    Jun 2, 2003
    Messages:
    15,914
    Likes Received:
    326
    A disable would be nice. I hate collapsed quotes and find no redeeming value in them whatsoever, though you guys have done pretty well with the feature itself.
     
  27. StarMonkey

    StarMonkey ValveTime Admin | Mighty Pirate
    Staff Member

    Joined:
    Jul 23, 1981
    Messages:
    1,612
    Likes Received:
    23
    I like it!
     
  28. NeptuneUK

    NeptuneUK Space Core

    Joined:
    Aug 25, 2004
    Messages:
    4,448
    Likes Received:
    11
    This feature has my unwavering approval!
     
  29. Destructo-Bot

    Joined:
    Jun 15, 2006
    Messages:
    273
    Likes Received:
    6
    If you have a minimum font size specified in your browser the quote tab blocks the text of the post (collapsed AND un-collapsed). I'd recommend making the containing box wider to accommodate various font sizes instead of butting the edges right up against the text.
     

    Attached Files:

  30. Destructo-Bot

    Joined:
    Jun 15, 2006
    Messages:
    273
    Likes Received:
    6
    Bumping, are we leaving the quote tab able to overflow or is it being looked into?
     
  31. Chris D

    Chris D Administrator.
    Staff Member

    Joined:
    Jul 1, 2003
    Messages:
    11,909
    Likes Received:
    402
    It is being looked into.
     
  32. Dog--

    Dog-- The Freeman

    Joined:
    Apr 16, 2005
    Messages:
    9,743
    Likes Received:
    55
    CBA to read this entire thread so this has probably been said, but I like it. It looks nice and neat. It's quick and easy. I especially like it for those certain people who LOVE quoting the hugest biggest posts they can find and reply with "lol".
     
    • Like Like x 1
  33. Chris D

    Chris D Administrator.
    Staff Member

    Joined:
    Jul 1, 2003
    Messages:
    11,909
    Likes Received:
    402
    lol
     
    • Like Like x 2
  34. Hubicorn

    Hubicorn Hunter

    Joined:
    Sep 2, 2012
    Messages:
    3
    Likes Received:
    8
    This is pretty amazing! I do have to say you guys made a great choice from switching forum software's. I've never been part of a community using XenForo and I am really enjoying using it here.
     
    • Like Like x 1
  35. Destructo-Bot

    Joined:
    Jun 15, 2006
    Messages:
    273
    Likes Received:
    6
    The quote tab still overlaps the quoted text if you have a minimum font size specified ;)
     

Share This Page